• PrettyFlyForAFatGuy@lemmy.ml
    link
    fedilink
    arrow-up
    20
    ·
    8 months ago

    Lead of a small team of scripters here. The “Why. Not What” is defo a good way of encouraging cleaner code.

    Had to request changes recently on a PR like this, big function with comments telling me what it was doing. When they resubmitted for review they had broken it down into smaller functions with good variable/function naming. following what was going on was much easier

    • AA5B@lemmy.world
      link
      fedilink
      arrow-up
      1
      ·
      8 months ago

      Same strategy here, but recently found myself commenting on the “what”. There was a perfect built-in, but not really readable and I couldn’t figure out how to make it readable, so fine